fix version placeholder for editable installs#75
Open
st3r4g wants to merge 1 commit intomatthewcarbone:masterfrom
Open
fix version placeholder for editable installs#75st3r4g wants to merge 1 commit intomatthewcarbone:masterfrom
st3r4g wants to merge 1 commit intomatthewcarbone:masterfrom
Conversation
st3r4g
force-pushed
the
fix-editable-install
branch
from
53baea0 to
d26ef29
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openjournals/joss-reviews#5115
The old "ellipsis" placeholder prevented to perform editable installs, with a rather obscure error message. Here I change it to a string which is valid and shows that the user has some development version installed by editable install. In this way no dependence on any dynamic version generator is needed.
#63