Upgrade node version to 20.11 #47
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Upgrade the node version to 20.11 and update related configuration files.
- Updated the node version per the PR title.
- Fixed the Babel plugin name for object rest/spread support in the configuration.
Files not reviewed (2)
- .nvmrc: Language not supported
- webapp/package.json: Language not supported
Comments suppressed due to low confidence (1)
webapp/babel.config.js:31
- The plugin name has been updated to match the official Babel naming convention. Please confirm that '@babel/proposal-object-rest-spread' is deprecated and the new name '@babel/plugin-proposal-object-rest-spread' is intended.
'@babel/plugin-proposal-object-rest-spread',
BenCookie95
requested changes
May 16, 2025
| "@babel/core": "7.24.7", | ||
| "@babel/plugin-proposal-class-properties": "7.18.6", | ||
| "@babel/plugin-proposal-object-rest-spread": "7.20.7", | ||
| "@babel/plugin-proposal-optional-chaining": "7.21.0", |
Contributor
There was a problem hiding this comment.
I don't think we still need all these? I removed them when updating the plugin starter template https://github.com/mattermost/mattermost-plugin-starter-template/pull/213/files#diff-006cce2fd88392a0bff4cf16091d480b6238c6bdf52c9042bf7805879c791a8f
| '@babel/plugin-syntax-dynamic-import', | ||
| '@babel/proposal-object-rest-spread', | ||
| '@babel/plugin-proposal-object-rest-spread', | ||
| '@babel/plugin-proposal-optional-chaining', |
Contributor
There was a problem hiding this comment.
Do we still need all these?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade node version to 20.11