fix: fix migrate token balances gw to l1 #1908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkzoomer
changed the title
…migrate-token-balances-gw-to-l1
kelemeno
reviewed
Dec 5, 2025
kelemeno
reviewed
Dec 5, 2025
kelemeno
reviewed
Dec 5, 2025
kelemeno
reviewed
Dec 5, 2025
zkzoomer
changed the title
zkzoomer
requested review from
StanislavBreadless and
vladbochok
as code owners
…migrate-token-balances-gw-to-l1
This reverts commit cdca41e.
kelemeno
reviewed
Dec 16, 2025
|
|
||
| // We check the assetId to make sure the chain is not lying about it. | ||
| DataEncoding.assetIdCheck(data.tokenOriginChainId, data.assetId, data.originToken); | ||
| if (data.assetId != BRIDGE_HUB.baseTokenAssetId(data.tokenOriginChainId)) { |
Contributor
There was a problem hiding this comment.
just leaving this comment here, so we don't forget to remove this check
This reverts commit a826358.
…migrate-token-balances-gw-to-l1
…migrate-token-balances-gw-to-l1
# What ❔
* [x] publish release artifacts only on tag pushes
<!-- What are the changes this PR brings about? -->
<!-- Example: This PR adds a PR template to the repo. -->
<!-- (For bigger PRs adding more context is appreciated) -->
## Why ❔
This was caused by this condition:
```
create:
tags:
- "v*" # for main releases
- "zkos*" # for zk releases
```
There is no `on:create` filter for tags, so are firing the release
generation each time a new branch is created.
The proper fix is:
```
push:
tags:
- "v*" # for main releases
- "zkos*" # for zk releases
```
<!-- Why are these changes done? What goal do they contribute to? What
are the principles behind them? -->
<!-- Example: PR templates ensure PR reviewers, observers, and future
iterators are in context about the evolution of repos. -->
## Checklist
<!-- Check your PR fulfills the following items. --> <!-- For draft PRs
check the boxes as you complete them. -->
- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [x] Tests for the changes have been added / updated.
- [x] Documentation comments have been added / updated.
# What ❔
<!-- What are the changes this PR brings about? -->
<!-- Example: This PR adds a PR template to the repo. -->
<!-- (For bigger PRs adding more context is appreciated) -->
## Why ❔
<!-- Why are these changes done? What goal do they contribute to? What
are the principles behind them? -->
<!-- Example: PR templates ensure PR reviewers, observers, and future
iterators are in context about the evolution of repos. -->
## Checklist
<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->
- [ ] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
zkzoomer
changed the title
|
Coverage after merging sma/fix-migrate-token-balances-gw-to-l1 into kl/medium-interop will be
Coverage Report |
kelemeno
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
This is a sister-ish PR to matter-labs/zksync-era#4591
Why ❔
Checklist