Open
Conversation
Remove info[:rank].to_i != 10 in line 766 and info[:rank].to_i != 5 unless they have more significance. Causes endless loops at ranks 5/10. Add/Modify at elsif statment line 789 to pause for trading tasks without vouchers.
restored the 10 and 5 rank portions of the if statements (still creates a loop but I haven't investigated the fix) Moved the wait logic under 'no task' instead of under 'go gather ingredients' section. Added if statements for the particular capture group.
Fixed a logic issue and updated the placement of the regexes for matching the wait timer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor updates for changes to guild task trading and waiting for the the cooldown for another task.