Advertise the XMPP network in the room directory (thirdparty protocols) - #381
Open
ara4n wants to merge 3 commits into
Open
Advertise the XMPP network in the room directory (thirdparty protocols)#381ara4n wants to merge 3 commits into
ara4n wants to merge 3 commits into
Conversation
Three pieces that let clients browse this bridge's rooms via the network
dropdown in a room directory (Show: XMPP in Element):
- the generated registration now includes protocols: [xmpp], so the
homeserver associates the appservice with the network
- serve the third-party lookup (thirdPartyLookup controller): synapse
queries GET /_matrix/app/v1/thirdparty/protocol/xmpp to populate
/_matrix/client/v3/thirdparty/protocols with the XMPP instance
- publish portal rooms to the appservice room list
(PUT /directory/list/appservice/xmpp/{roomId}), which is what a
publicRooms query filtered by third_party_instance_id returns; portals
predating this change are republished the next time their alias is
queried (the existing-portal path publishes too, idempotently)
|
@ara4n: Happy to see your PR, thanks for your work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the three pieces needed for bridged rooms to appear under an XMPP network in clients' room directories:
protocols: ["xmpp"]in the generated registration, athirdPartyLookupcontroller so the AS/thirdparty/*endpoints are mounted (and/_matrix/client/v3/thirdparty/protocolslists the bridge), and publishing portal rooms to the appservice room list on creation (plus a backfill on the existing-portal alias-query path).this PR was generated by Fable but reviewed by hand