change create.rs

[donjuanplatinum]

in the synapse room.py line 1690

        if config["guest_can_join"]:
            if (EventTypes.GuestAccess, "") not in initial_state:
                guest_access_event, guest_access_context = await create_event(
                    EventTypes.GuestAccess,
                    {EventContentFields.GUEST_ACCESS: GuestAccess.CAN_JOIN},
                    True,
                )
                events_to_send.append((guest_access_event, guest_access_context))

it says that: only guest_can_join == true, it will create and return guest_access event.

in the past tuwunel create.rs line 246 : it will create and return guest_access anyway.

	// 5.3 Guest Access
	services
		.timeline
		.build_and_append_pdu(
			PduBuilder::state(
				String::new(),
				&RoomGuestAccessEventContent::new(match preset {
					| RoomPreset::PublicChat => GuestAccess::Forbidden,
					| _ => GuestAccess::CanJoin,
				}),
			),
			sender_user,
			&room_id,
			&state_lock,
		)
		.boxed()
		.await?;

[dasha-uwu]

why should we do this? the spec doesn't say to. in fact it says the opposite:

It MUST apply the events implied by the request in the following order:
...
Events set by the preset. Currently these are the m.room.join_rules, m.room.history_visibility, and m.room.guest_access state events.

it doesn't say we should or just can skip the events. synapse is wrong here.

[jevolk]

I have applied a workaround in Complement in lieu of this PR for now. We needed one or the other to merge #349. This is marked as draft so we can double-back on that decision as necessary.