Segment selector: max out at 5-6, instead of throwing many errors in reporting interface #23792
+86
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f adding the segment into the store to finish before we 'mark' icons as 'compared'
…of 'data_comparison_segment_limit' to include the count for the first segment to compare (Usually 'All Visits').
… will stop click events on the element
…lick event to 'markCurrentSegment'
…ppening when tests are run in the server
…dSegment' and it must equal to our MaximumLimit
chippison
commented
Nov 22, 2025
Contributor
Author
There was a problem hiding this comment.
Updated General.data_comparison_limit
nathangavin
approved these changes
Nov 24, 2025
Contributor
nathangavin
left a comment
nathangavin
left a comment
There was a problem hiding this comment.
Looks good to me. Left a comment regarding the use of setTimeout.
|
|
||
| self.markComparedSegments(); | ||
|
|
||
| setTimeout(function () { |
Contributor
There was a problem hiding this comment.
This is a bit of an odd use of setTimeout(), perhaps theres an event to listen for, or some other change to trigger the update on?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
UX-340
From JIRA issue:
Checklist
Review