Skip to content

Conversation

@sgiehl
Copy link
Member

@sgiehl sgiehl commented Oct 30, 2025

Description:

Checklist

  • [✔] I have understood, reviewed, and tested all AI outputs before use
  • [✔] All AI instructions respect security, IP, and privacy rules

Review

@sgiehl sgiehl force-pushed the dev-19555 branch 10 times, most recently from 308560f to 51d0da8 Compare October 31, 2025 17:33
@sgiehl sgiehl marked this pull request as ready for review October 31, 2025 17:33
@sgiehl sgiehl requested a review from a team October 31, 2025 17:33
Copy link
Member Author

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: We need to update the tracking documentation afterwards. I'll create a PR for that once this PR has an approval.

@mneudert mneudert removed their assignment Nov 6, 2025
@sgiehl sgiehl force-pushed the dev-19555 branch 3 times, most recently from 3a45a8b to 6607f42 Compare November 7, 2025 07:42
@sgiehl sgiehl requested a review from mneudert November 7, 2025 08:34
sgiehl added a commit to matomo-org/developer-documentation that referenced this pull request Nov 7, 2025
Expanded the documentation on bot tracking capabilities and parameters in Matomo, including details on request processing modes and specific parameters evaluated during bot tracking introduced with matomo-org/matomo#23725
Copy link
Contributor

@michalkleiner michalkleiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Purely looking at the changes since Marc's latest review, there's just one more place where we can use the logger interface mechanism instead of Common::printDebug.

I'd have one more question on top of that and that is whether it's ok to limit the deletion to 25000 records. Is that sufficient, or would we need to run the call in a loop until there's nothing to delete?

@sgiehl sgiehl force-pushed the dev-19555 branch 2 times, most recently from e7920ce to f622e04 Compare November 18, 2025 09:24
@caddoo caddoo self-assigned this Nov 19, 2025
caddoo
caddoo previously approved these changes Nov 20, 2025
Copy link
Contributor

@caddoo caddoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this manually locally, works as expected the existing tracking of course works as well.

I like the BC approach, simple.

Just a couple questions that aren't blocking.

@sgiehl sgiehl force-pushed the dev-19555 branch 2 times, most recently from a8a4d78 to 19a3fe9 Compare November 20, 2025 09:06
@sgiehl sgiehl requested a review from caddoo November 20, 2025 09:10
@sgiehl sgiehl force-pushed the dev-19555 branch 3 times, most recently from 0857cf8 to 2559320 Compare November 21, 2025 15:10
@sgiehl sgiehl modified the milestones: 5.7.0, Impact backlog Nov 21, 2025
@sgiehl sgiehl removed the request for review from michalkleiner November 24, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants