-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Track AI Bots through our HTTP Tracking API #23725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 5.x-dev
Are you sure you want to change the base?
Conversation
308560f to
51d0da8
Compare
sgiehl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: We need to update the tracking documentation afterwards. I'll create a PR for that once this PR has an approval.
faaf930 to
16239a0
Compare
3a45a8b to
6607f42
Compare
Expanded the documentation on bot tracking capabilities and parameters in Matomo, including details on request processing modes and specific parameters evaluated during bot tracking introduced with matomo-org/matomo#23725
michalkleiner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Purely looking at the changes since Marc's latest review, there's just one more place where we can use the logger interface mechanism instead of Common::printDebug.
I'd have one more question on top of that and that is whether it's ok to limit the deletion to 25000 records. Is that sufficient, or would we need to run the call in a loop until there's nothing to delete?
e7920ce to
f622e04
Compare
caddoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested this manually locally, works as expected the existing tracking of course works as well.
I like the BC approach, simple.
Just a couple questions that aren't blocking.
a8a4d78 to
19a3fe9
Compare
0857cf8 to
2559320
Compare
…no longer called with Matomo 6
Description:
Checklist
Review