build: use pyproject.toml #41
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathurinm
reviewed
Apr 29, 2025
|
|
||
| [project] | ||
| name = "libsvmdata" | ||
| dynamic = ["version"] |
Owner
There was a problem hiding this comment.
I think you also need to specify where it is defined, like we do here : https://github.com/scikit-learn-contrib/skglm/blob/main/pyproject.toml#L36
Owner
There was a problem hiding this comment.
yep, so far it's thinking this is version 0.0.0:
Successfully uninstalled libsvmdata-0.5.dev0
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
celer 0.7.3.dev0 requires libsvmdata>=0.3, but you have libsvmdata 0.0.0 which is incompatible.
Successfully installed libsvmdata-0.0.0
Collaborator
Author
There was a problem hiding this comment.
Of course, thanks! Fixed it now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the current use of
setup.cfg,setup.py, andrequremtents.txtintopyproject.toml.