Skip to content

Properly handle margin-left and margin-right specified on the input elements.#1456

Open
dpvc wants to merge 1 commit intodevelopfrom
fix/margin-spacing
Open

Properly handle margin-left and margin-right specified on the input elements.#1456
dpvc wants to merge 1 commit intodevelopfrom
fix/margin-spacing

Conversation

@dpvc
Copy link
Copy Markdown
Member

@dpvc dpvc commented Apr 7, 2026

This PR fixes the output jax to take margin css into account when positioning elements and computing their widths. The code already handles padding and border CSS, so this adds similar support for margin. This is needed in order to support the next PR to work around a bug in Safari that affects bussproof layouts.

@dpvc dpvc requested a review from zorkow April 7, 2026 14:26
@dpvc dpvc added this to the v4.2 milestone Apr 7, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

❌ Patch coverage is 11.42857% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.42%. Comparing base (da21770) to head (e4cb499).
⚠️ Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
ts/output/common/Wrapper.ts 13.04% 20 Missing ⚠️
ts/output/svg/Wrapper.ts 8.33% 11 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1456      +/-   ##
===========================================
- Coverage    86.45%   86.42%   -0.03%     
===========================================
  Files          340      340              
  Lines        86106    86133      +27     
  Branches      3191     4836    +1645     
===========================================
+ Hits         74439    74442       +3     
- Misses       11667    11691      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant