feat: add .ets、.d.ets icons and remove .ets、.d.ets from TypeScript#3191
Open
Groupguanfang wants to merge 1 commit intomaterial-extensions:mainfrom
Open
feat: add .ets、.d.ets icons and remove .ets、.d.ets from TypeScript#3191Groupguanfang wants to merge 1 commit intomaterial-extensions:mainfrom
.ets、.d.ets icons and remove .ets、.d.ets from TypeScript#3191Groupguanfang wants to merge 1 commit intomaterial-extensions:mainfrom
Conversation
Contributor
PreviewThank you for creating a pull request. This preview shows you how your icons will look on the different themes: Check how your icons fit in a 16x16 grid with our Pixel Perfect Checker by following this link. You can find more information on how to contribute in the contribution guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Not long ago, I directly mapped the file icons of
.etsand.d.etsto TypeScript (#2966). Now, I have submitted anets.svgandets-def.svgicons, it modified based ontypescript.svgandtypescript-def.svgicons, and changed their colors to the theme color of the ETS file (See: github-linguist/linguist#7593 (comment)).This icon is composed of the three letters
ETS, and I don't know if it will create a visually overly complicated effect. I have only made this modification for now, because the.etsfile does not have an official file icon for material design.In the Catppuccin Icons for VSCode repository, they have an issue that states what the file icons look like in the official IDE for developing HarmonyOS Apps (their IDE is based on IntelliJ IDEA): catppuccin/vscode-icons#570
My suggestion is that the icon for the ETS file should be directly modified from the icon of the TS file or keep to using the original TS file icons, because the icons in the official IDE do not have more reference value in this icon library.
Contribution Guidelines