Required components default fallback

[2387skju]

Reset the required components to default, if not found.
After uninstall a component, a fallback is need: will fix #324
(( Required components are: dock, filemanager, panel, window manager. ))

---

Changes in file mate-session/main.c :
Reset will be done, in this case:

• the executable was not found
• and the current value is not empty
  • => this still allows the user to disable a component manual (= by set empty value)
• and the default value is not empty

---

Additional just for the Windowmanager:
Changes in file data/mate-wm :

• checks if the value from gsettings is usable (command) ,
• otherwise just ignore that value and continue the script normal (= will search for another window manager)

(both shortly tested with older Mate Version 1.26 on Debian 13. ; I'm new in C-Language)

[vkareh]

There are some memory management issues, but this is moving in the right direction, thanks.

[2387skju]

Thanks for helping :-)

Changes:

• variable name swapped each other:
  • g_settings_default_default <=> default_default_provider
  • This is more consistent to the origin code (the lines before).
• replaced:
  • old: strcmp(myString, "") != 0
  • new: myString[0] != '\0'
  • The return of g_settings_get_string and g_variant_get_string is NUL terminated. ( NULL is not mentioned here in glib doku.)
• replaced:
  • old: g_variant_get
  • new: g_variant_get_string
  • This is compare-able like &s version of g_variant_get.
  • I think this look a little bit bedder. (but not important)

---

Split code in a new function ? :

A suggestion:
Just an Idea. I'm not sure about it. The benefit is not very deep, in total just a few lines less.
In this structure:

append_required_apps_add_component (...,  gboolean is_recursive_call)
{

  [...] // code do add component
  
  if  // if failed && ! is_recursive_call
  {
    // code do reset
    ...
    append_required_apps_add_component (..., TRUE);
  }
}

append_required_apps ()
{
  for  // for each required_components
  {
    append_required_apps_add_component (..., FALSE);
  }
}

This function implemented in Code:

• This branch or commit
• ((( or the same, with an extra refactor commit: branch or commit ))

[vkareh]

@2387skju this looks a lot better, thanks! I think you have a good suggestion there with the function, it will make things easier to understand for sure.

[vkareh]

This is looking great! Just some minor nitpicks before this is ready

[2387skju]

Sorry, I messed up a commit and tried to clean it. Please just take a look at the last Diff-Compare in GitHub: This one is from before last review f9f03f8 to the current state 98da258.

[L-U-T-i]

I am getting a build error with the latest patch:

main.c: In function 'append_required_apps_add_component':
main.c:283:50: error: 'g_settings_default_default' undeclared (first use in this function); did you mean 'gtk_settings_get_default'?
  283 |                                 g_variant_unref (g_settings_default_default);
      |                                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                                  gtk_settings_get_default

It seems to me you've renamed g_settings_default_default to schema_default, but you've forgotten to replace it here.

After I've changed:
g_variant_unref (g_settings_default_default);
to:
g_variant_unref (schema_default);
the build went through as expected.

[2387skju]

@L-U-T-i: Thank you for helping :-)

I've just forget to delete this line in my committed version.

Here you see a bedder human readable, corrected git history of the last changes