fix switch-windows-all hotkey

[dnk]

pass focus to window if it is on another workspace.

current behavior:

1. there are 2 windows on workspace A and window 2 is above window 1
2. switch to workspace B
3. use "switch-windows-all" keys to switch to window 1

actual result:
window 1 get "demands attention" mark.
focus passed to window 2.

with this changes:
focus passed to window 1. window 1 is raised above all normal windows.

there is still problem with stealing focus by "always on top" windows. it can fixed separately.

[dnk]

known problem:
scenario:
there are 2+ monitors
workspace 1:

• application A on monitor 1
• application B (Atom text editor) on monitor 2
  active workspace 2
  switch to application A using "switch-windows-all" hotkey

actual result:
application B (Atom text editor) on monitor 2 displays invalid image.

the same problem appeared by just switching workspaces.

may be there is bug in Atom text editor.

[Rambo1377]

src/core/window.c

[lukefromdc]

This isn't something I can easily test as its so far outside my workflow. I have never used a switch-windows-all hotkey and the entire described workflow is out of my experience.It would not be visually obvious to me if this was working right or not.

We have one approving review and the code change itself is simple. Hoping we can get a second review on this.

[vkareh]

I can confirm the issue. However, in your comments you mentioned that "always on top" windows will be addressed separately, but this commit seems to only address "always on top" windows.

In either case. The changes here do not fix the issue for me on either regular windows or "always on top" windows.