Implement logic and functionality in TodoApp#1259
Open
TaniaFedortsi wants to merge 2 commits intomate-academy:masterfrom
Open
Implement logic and functionality in TodoApp#1259TaniaFedortsi wants to merge 2 commits intomate-academy:masterfrom
TaniaFedortsi wants to merge 2 commits intomate-academy:masterfrom
Conversation
Denys-Kravchuk9988
suggested changes
Jan 17, 2026
Denys-Kravchuk9988
left a comment
Denys-Kravchuk9988
left a comment
There was a problem hiding this comment.
Good work!
A few things to improve:
- It looks like this block overflows its container.
- Disabled button should not have hover state (underline) and I would recommend to add disabled color (make opacity 0.8 for example or add custom disabled color)
src/components/Footer.tsx
Outdated
| return ( | ||
| <footer className="todoapp__footer" data-cy="Footer"> | ||
| <span className="todo-count" data-cy="TodosCounter"> | ||
| {`${todos.filter(todo => !todo.completed).length} items left`} |
There was a problem hiding this comment.
It's better to extract this expression to a separate constant
| <div | ||
| key={todo.id} | ||
| data-cy="Todo" | ||
| className={classNames('todo', { ' completed': todo.completed })} |
| onSubmit={e => { | ||
| e.preventDefault(); | ||
| updateTodo(todo.id); | ||
| }} |
There was a problem hiding this comment.
It's better to move these actions in a separate callback. Something like handleSubmit or handleUpdate
| setEditing(null); | ||
| setNewTitle(''); | ||
| } | ||
| }} |
There was a problem hiding this comment.
Same here. It's better to move these actions in a separate callback
| className="todo__title" | ||
| onDoubleClick={() => { | ||
| setEditing(todo.id); | ||
| setNewTitle(todo.title); |
|
Good job! |
Denys-Kravchuk9988
approved these changes
Jan 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://taniafedortsi.github.io/react_todo-app/