Open
Conversation
brespect
suggested changes
Mar 20, 2026
brespect
left a comment
brespect
left a comment
There was a problem hiding this comment.
Seems like, task is not completed, pass all tests and linter check, and also don`t forget to add the DEMO LINK to the PRs description.
Author
|
2pasha
suggested changes
Mar 23, 2026
2pasha
left a comment
2pasha
left a comment
There was a problem hiding this comment.
good job! 👏
here are some improvements:
- please pass all tests
- input is smaller than in reference
ref:
- fix comments below
Comment on lines
+119
to
+123
| onSubmit={e => { | ||
| e.preventDefault(); | ||
| finishEdit('submit'); | ||
| }} | ||
| > |
Comment on lines
+28
to
+61
| <nav className="filter" data-cy="Filter"> | ||
| <button | ||
| type="button" | ||
| className={classNames('filter__link', { | ||
| selected: filterStatus === Status.All, | ||
| })} | ||
| data-cy="FilterLinkAll" | ||
| onClick={() => setFilterStatus(Status.All)} | ||
| > | ||
| All | ||
| </button> | ||
|
|
||
| <button | ||
| type="button" | ||
| className={classNames('filter__link', { | ||
| selected: filterStatus === Status.Active, | ||
| })} | ||
| data-cy="FilterLinkActive" | ||
| onClick={() => setFilterStatus(Status.Active)} | ||
| > | ||
| Active | ||
| </button> | ||
|
|
||
| <button | ||
| type="button" | ||
| className={classNames('filter__link', { | ||
| selected: filterStatus === Status.Completed, | ||
| })} | ||
| data-cy="FilterLinkCompleted" | ||
| onClick={() => setFilterStatus(Status.Completed)} | ||
| > | ||
| Completed | ||
| </button> | ||
| </nav> |
There was a problem hiding this comment.
you may add all you filter values into enum and through it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.