Conversation
There was a problem hiding this comment.
Checked this link
https://adadiada.github.io/react_todo-app-with-api/
It seems that project wasn't deployed yet. Please, deploy the project and provide DEMO LINK.
Also try to pass all tests
src/component/Error.tsx
Outdated
| return ( | ||
| <div | ||
| data-cy="ErrorNotification" | ||
| className={`notification is-danger is-light has-text-weight-normal ${ |
There was a problem hiding this comment.
It's better to use classNames here
src/component/Footer.tsx
Outdated
| <nav className="filter" data-cy="Filter"> | ||
| <a | ||
| href="#/" | ||
| className={`filter__link ${filter === Filter.All ? 'selected' : ''}`} |
There was a problem hiding this comment.
It's better to use classNames here
src/component/Footer.tsx
Outdated
|
|
||
| <a | ||
| href="#/active" | ||
| className={`filter__link ${filter === Filter.Active ? 'selected' : ''}`} |
There was a problem hiding this comment.
It's better to use classNames here
| className={`filter__link ${filter === Filter.Active ? 'selected' : ''}`} | ||
| data-cy="FilterLinkActive" | ||
| onClick={e => { | ||
| e.preventDefault(); |
There was a problem hiding this comment.
I would recommend to extract this code into a separate callback
src/component/Footer.tsx
Outdated
|
|
||
| <a | ||
| href="#/completed" | ||
| className={`filter__link ${filter === Filter.Completed ? 'selected' : ''}`} |
There was a problem hiding this comment.
It's better to use classNames here
src/component/Footer.tsx
Outdated
| className="todoapp__clear-completed" | ||
| data-cy="ClearCompletedButton" | ||
| disabled={!hasCompleted} | ||
| onClick={() => { |
There was a problem hiding this comment.
I would recommend to shorten click handler like this onClick={onClear}
src/component/Header.tsx
Outdated
| {todos.length > 0 && ( | ||
| <button | ||
| type="button" | ||
| className={ |
There was a problem hiding this comment.
It's better to use classNames here
|
|
||
| return ( | ||
| <section | ||
| className={`todoapp__main ${(todos.length === 0 && !tempTodo) || loading ? 'hidden' : ''}`} |
There was a problem hiding this comment.
It's better to use classNames here
| type="checkbox" | ||
| className="todo__status" | ||
| checked={todo.completed} | ||
| onChange={() => |
There was a problem hiding this comment.
It's better to shorten the callback structure onChange={() => handleUpdateTodo({ ...todo, completed: !todo.completed })}
src/component/Error.tsx
Outdated
| data-cy="HideErrorButton" | ||
| type="button" | ||
| className="delete" | ||
| onClick={() => { |
There was a problem hiding this comment.
It's better to shorten click handler like this onClick={() => onCloseError()}
brespect
left a comment
brespect
left a comment
There was a problem hiding this comment.
Seems like, you still didnt deploy your solution. Also, check all previous mentors comments and try to pass all tests before requesting the review:
3 participants
No description provided.