Skip to content
Open

Develop #2145

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,4 @@ Implement the ability to edit a todo title on double click:

- Implement a solution following the [React task guideline](https://github.com/mate-academy/react_task-guideline#react-tasks-guideline).
- Use the [React TypeScript cheat sheet](https://mate-academy.github.io/fe-program/js/extra/react-typescript).
- Replace `<your_account>` with your Github username in the [DEMO LINK](https://<your_account>.github.io/react_todo-app-with-api/) and add it to the PR description.
- Replace `<your_account>` with your Github username in the [DEMO LINK](https://chumachenkoUA.github.io/react_todo-app-with-api/) and add it to the PR description.
9 changes: 5 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
},
"devDependencies": {
"@cypress/react18": "^2.0.1",
"@mate-academy/scripts": "^1.8.5",
"@mate-academy/scripts": "^2.1.3",
"@mate-academy/students-ts-config": "*",
"@mate-academy/stylelint-config": "*",
"@types/node": "^20.14.10",
Expand Down
254 changes: 238 additions & 16 deletions src/App.tsx
Original file line number Diff line number Diff line change
@@ -1,26 +1,248 @@
/* eslint-disable max-len */
/* eslint-disable jsx-a11y/control-has-associated-label */
import React from 'react';
import React, { useEffect, useRef, useState } from 'react';
import * as postService from './api/todos';
import { UserWarning } from './UserWarning';

const USER_ID = 0;
import { Todo } from './types/Todo';
import { Header } from './components/Header';
import { Footer } from './components/Footer';
import { ErrorMessage } from './types/ErrorMessage';
import { Filter } from './types/Filter';
import { TodoList } from './components/TodoList';
import { ErrorNotification } from './components/ErrorNotification';

export const App: React.FC = () => {
if (!USER_ID) {
const [todos, setTodos] = useState<Todo[]>([]);
const [errorMessage, setErrorMessage] = useState<ErrorMessage | null>(null);
const [filter, setFilter] = useState<Filter>(Filter.All);
const [isSubmitting, setIsSubmitting] = useState<boolean>(false);
const [tempTodo, setTempTodo] = useState<Todo | null>(null);
const [title, setTitle] = useState('');
const [deletingTodoIds, setDeletingTodoIds] = useState<number[]>([]);
const [updatingTodoIds, setUpdatingTodoIds] = useState<number[]>([]);

const activeTodos = todos.filter(todo => !todo.completed);
const activeTodosCount = activeTodos.length;
const completedTodosCount = todos.length - activeTodosCount;
const allTodosCompleted = activeTodosCount === 0 && todos.length !== 0;

const inputRef = useRef<HTMLInputElement>(null);

const loadTodos = async () => {
try {
const todosFromServer = await postService.getTodos();

setTodos(todosFromServer);
} catch {
setErrorMessage(ErrorMessage.LoadTodos);
}
};

const filteredTodos = todos.filter((todo: Todo) => {
if (filter === Filter.Active) {
return !todo.completed;
}

if (filter === Filter.Completed) {
return todo.completed;
}

return true;
});

const onFilterChange = (value: Filter) => {
setFilter(value);
};

const onTitleChange = (newTitle: string) => {
setTitle(newTitle);
};

const handleErrorClose = () => {
setErrorMessage(null);
};

const deleteTodo = async (todoId: number) => {
setErrorMessage(null);

try {
setDeletingTodoIds(prev => [...prev, todoId]);
await postService.deleteTodo(todoId);
setTodos(prev => prev.filter(todo => todo.id !== todoId));
} finally {
setDeletingTodoIds(prev => prev.filter(id => id !== todoId));
}
};

const handleDeleteOneTodo = async (todoId: number) => {
setErrorMessage(null);

try {
await deleteTodo(todoId);
} catch {
setErrorMessage(ErrorMessage.DeleteTodo);
throw new Error();
}
};

const handleClearCompleted = async () => {
setErrorMessage(null);

const completeTodoIds = todos
.filter(completedTodo => completedTodo.completed)
.map(completedTodo => completedTodo.id);

const results = await Promise.allSettled(
completeTodoIds.map(id => deleteTodo(id)),
);

const hasRejected = results.some(result => result.status === 'rejected');

if (hasRejected) {
setErrorMessage(ErrorMessage.DeleteTodo);
}
};

const addTodo = async (newTitle: string) => {
setErrorMessage(null);

const clearTitle = newTitle.trim();

if (clearTitle.length === 0) {
setErrorMessage(ErrorMessage.EmptyTitle);

return;
}

const temporaryTodo: Todo = {
id: 0,
userId: postService.USER_ID,
title: clearTitle,
completed: false,
};

try {
setIsSubmitting(true);
setTempTodo(temporaryTodo);
const newTodo = await postService.createTodo(clearTitle);

setTodos(prev => [...prev, newTodo]);
setTitle('');
} catch {
setErrorMessage(ErrorMessage.AddTodo);
} finally {
setIsSubmitting(false);
setTempTodo(null);
}
};

const updateTodo = async (
todoId: number,
newTitle: string,
completed: boolean,
) => {
setErrorMessage(null);
setUpdatingTodoIds(prev => [...prev, todoId]);
try {
const updatedTodo = await postService.updateTodo(
todoId,
newTitle,
completed,
);

setTodos(prev =>
prev.map(todo => (todo.id === todoId ? updatedTodo : todo)),
);
} catch {
setErrorMessage(ErrorMessage.UpdateTodo);
throw new Error();
} finally {
setUpdatingTodoIds(prev => prev.filter(id => id !== todoId));
}
};

const handleToggleAll = async () => {
setErrorMessage(null);
const newCompletedStatus = !allTodosCompleted;
const futureUpdatedTodos = todos.filter(
todo => todo.completed !== newCompletedStatus,
);

const results = await Promise.allSettled(
futureUpdatedTodos.map(todo =>
updateTodo(todo.id, todo.title, newCompletedStatus),
),
);
const hasRejected = results.some(result => result.status === 'rejected');

if (hasRejected) {
setErrorMessage(ErrorMessage.UpdateTodo);
}
};

useEffect(() => {
if (!isSubmitting && deletingTodoIds.length === 0) {
inputRef.current?.focus();
}
}, [isSubmitting, deletingTodoIds]);

useEffect(() => {
loadTodos();
}, []);

useEffect(() => {
if (!errorMessage) {
return;
}

const timer = setTimeout(() => setErrorMessage(null), 3000);

return () => clearTimeout(timer);
}, [errorMessage]);

if (!postService.USER_ID) {
return <UserWarning />;
}

return (
<section className="section container">
<p className="title is-4">
Copy all you need from the prev task:
<br />
<a href="https://github.com/mate-academy/react_todo-app-add-and-delete#react-todo-app-add-and-delete">
React Todo App - Add and Delete
</a>
</p>

<p className="subtitle">Styles are already copied</p>
</section>
<div className="todoapp">
<h1 className="todoapp__title">todos</h1>

<div className="todoapp__content">
<Header
allTodosCompleted={allTodosCompleted}
title={title}
onTitleChange={onTitleChange}
addTodo={addTodo}
isSubmitting={isSubmitting}
inputRef={inputRef}
handleToggleAll={handleToggleAll}
hasTodos={todos.length > 0}
/>

<TodoList
visibleTodos={filteredTodos}
tempTodo={tempTodo}
handleDeleteTodo={handleDeleteOneTodo}
deletingTodoIds={deletingTodoIds}
updatingTodoIds={updatingTodoIds}
updateTodo={updateTodo}
/>

{todos.length !== 0 && (
<Footer
activeTodosCount={activeTodosCount}
completedTodosCount={completedTodosCount}
filter={filter}
onFilterChange={onFilterChange}
handleClearCompleted={handleClearCompleted}
/>
)}
</div>

<ErrorNotification
errorMessage={errorMessage}
onClose={handleErrorClose}
/>
</div>
);
};
28 changes: 28 additions & 0 deletions src/api/todos.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
import { Todo } from '../types/Todo';
import { client } from '../utils/fetchClient';

export const USER_ID = 4058;

export const getTodos = () => {
return client.get<Todo[]>(`/todos?userId=${USER_ID}`);
};

export const createTodo = (title: string) => {
return client.post<Todo>('/todos', {
userId: USER_ID,
title,
completed: false,
});
};

export const updateTodo = (id: number, title: string, completed: boolean) => {
return client.patch<Todo>(`/todos/${id}`, {
userId: USER_ID,
title,
completed,
});
};

export const deleteTodo = (id: number) => {
return client.delete(`/todos/${id}`);
};
35 changes: 35 additions & 0 deletions src/components/ErrorNotification/ErrorNotification.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
import React from 'react';
import cn from 'classnames';
import { ErrorMessage } from '../../types/ErrorMessage';

type Props = {
errorMessage: ErrorMessage | null;
onClose: () => void;
};

export const ErrorNotification: React.FC<Props> = ({
errorMessage,
onClose,
}) => {
return (
<div
data-cy="ErrorNotification"
className={cn(
'notification',
'is-danger',
'is-light',
'has-text-weight-normal',
{ hidden: !errorMessage },
)}
>
<button
data-cy="HideErrorButton"
type="button"
className="delete"
onClick={onClose}
/>
{/* show only one message at a time */}
{errorMessage}
</div>
);
};
1 change: 1 addition & 0 deletions src/components/ErrorNotification/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export * from './ErrorNotification';
Loading
Loading