Skip to content

Developer - #4433

Open
PAVLO111 wants to merge 4 commits into
mate-academy:masterfrom
PAVLO111:develop
Open

PAVLO111 wants to merge 4 commits into
mate-academy:masterfrom
PAVLO111:develop

Conversation

@PAVLO111

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your implementation is approved. All functional requirements are met: the Sum component correctly accepts props a and b, renders the expected output, uses default values of 0, and the App contains the required 5 instances. While the code uses separate JSX expressions instead of template literals for the output text (which differs from the preference expressed in checklist item 2), this is a style preference rather than a functional issue. The code works correctly and passes all tests. Consider updating the <p> content to use template literals like {`Sum of ${a} and ${b} is ${a + b}`} in future iterations, as this is more concise and is generally considered a best practice in React.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Comment thread src/App.jsx
import { Sum } from './components/Sum/Sum';

export const App = () => (
<>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item 2: Use string interpolation inside tag content. Replace with template literal: {Sum of ${a} and ${b} is ${c}}

Comment thread src/components/Sum/Sum.jsx Outdated
Comment on lines +5 to +6
<p>
Sum of {a} and {b} is {c}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item 2: Use string interpolation inside tag content. Replace with template literal: {Sum of ${a} and ${b} is ${a + b}}

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants