Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
I’m requesting changes because there is a violation of a specified checklist requirement, which is considered a core requirement for this task. Functionally, your Sum component and App usage are correct: props, defaults, named export, and multiple instances all work as expected. However, both src/App.jsx and src/components/Sum/Sum.jsx currently render the paragraph using separate JSX expressions like: Sum of {a} and {b} is {a + b}. This violates [CHECKLIST ITEM 2], which requires using a single template literal for tag content.
- What to fix (critical): In src/components/Sum/Sum.jsx (the paragraph line) and any similar usage in src/App.jsx, change to string interpolation with a template literal, for example: {
Sum of ${a} and ${b} is ${a + b}}. This ensures consistency with the checklist and keeps the content as a single interpolated string.
Once you make this adjustment, everything else looks solid and should fully meet the requirements. Great job on the functionality and structure—this is a quick style fix to align with the checklist.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
|
|
||
| export const App = () => ( |
There was a problem hiding this comment.
Checklist item 2 violation: Use string interpolation inside tag content. Replace Sum of {a} and {b} is {a + b} with {Sum of ${a} and ${b} is ${a + b}}
| <p> | ||
| Sum of {a} and {b} is {a + b} |
There was a problem hiding this comment.
This violates checklist item 2: Use string interpolation inside tag content. The content should use a template literal like {Sum of ${a} and ${b} is ${a + b}} instead of separate JSX expressions.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your solution fully meets all requirements. The Sum component correctly accepts a and b props with default values of 0, uses a named export, and renders the sum using template literal interpolation. [CHECKLIST ITEM 2] is satisfied with {Sum of ${a} and ${b} is ${a + b}}. The App component properly renders all 5 Sum instances on single lines as required by [CHECKLIST ITEM 1]. All functional and style requirements have been implemented correctly.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
This branch has not been deployed
2 participants
DEMO LINK