Skip to content

Implement Sum component - #4405

Open
loleksandra10-ops wants to merge 1 commit into
mate-academy:masterfrom
loleksandra10-ops:develop
Open

Implement Sum component#4405
loleksandra10-ops wants to merge 1 commit into
mate-academy:masterfrom
loleksandra10-ops:develop

Conversation

@loleksandra10-ops

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

I am requesting changes because the Sum component violates a required checklist item. In src/components/Sum/Sum.jsx, inside the <p> tag (around line where you render the message), you are not using string interpolation as required by [CHECKLIST ITEM #2]. The requirement is to use a template literal for the tag content, e.g., Sum of ${a} and ${b} is ${a + b}; without this, the code does not meet the explicit style rule. Please update the paragraph content to use a single template literal, like: {Sum of ${a} and ${b} is ${a + b}}.

  • Critical fix: Replace the existing concatenation or mixed expressions inside the <p> with a template literal string interpolation as specified above.

Everything else looks solid: App.jsx imports the Sum component correctly and includes all five required instances with the proper props. Once the interpolation is updated, this should meet all requirements. Good job overall—this is a quick fix to align with the checklist.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

export const Sum = ({ a = 0, b = 0 }) => {
return (
<p>
Sum of {a} and {b} is {a + b}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #2: Use string interpolation inside tag content. Change to: {Sum of ${a} and ${b} is ${a + b}}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants