Develop - #4403
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
The implementation is functionally complete and all Sum component requirements are met correctly. However, [CHECKLIST ITEM #2] is violated in src/components/Sum/Sum.jsx — the paragraph uses mixed text and JSX expressions (Sum of {a} and {b} is {a + b}) instead of template literal interpolation as explicitly required. Change line 4 from <p>Sum of {a} and {b} is {a + b}</p> to <p>{Sum of ${a} and ${b} is ${a + b}}</p> to align with the checklist requirements.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| import React from 'react'; | ||
| import { Sum } from './components/Sum/Sum'; | ||
| import './App.scss'; | ||
|
|
There was a problem hiding this comment.
This violates checklist item #2: Use string interpolation inside tag content. Use template literals instead: {Sum of ${a} and ${b} is ${a + b}}
| <p> | ||
| Sum of {a} and {b} is {a + b} |
There was a problem hiding this comment.
This violates checklist item #2: Use string interpolation inside tag content. The GOOD EXAMPLE shows <p>{Sum of ${a} and ${b} is ${a + b}}</p> but this code mixes text with JSX expressions {a}, {b}, {a + b} which is the 'BAD EXAMPLE' pattern.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your solution is approved. The App component uses a named export, correctly imports and renders the Sum component five times with the proper props, and follows the specified style rule of keeping elements with fewer than three attributes on a single line. The Sum component implements the required template literal interpolation and avoids mixing plain text with JSX expressions, aligning with the checklist. There are no functional or checklist-blocking issues observed, and the implementation meets all core requirements. Nice work maintaining consistency and readability throughout. Keep this level of clarity and adherence to conventions in future tasks.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
https://santana1719.github.io/react_sum/