Skip to content

done #4398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sofiatsebenko wants to merge 3 commits into
base: master
Choose a base branch
from
Open

done #4398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e1176aa
done
sofiatsebenko Aug 25, 2026
296e3fa
done 2
sofiatsebenko Aug 25, 2026
1cf28dc
done 2
sofiatsebenko Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
},
"devDependencies": {
"@cypress/react18": "^2.0.1",
"@mate-academy/scripts": "^1.8.5",
"@mate-academy/scripts": "^2.1.3",
"@mate-academy/stylelint-config": "*",
"@vitejs/plugin-react": "^4.3.1",
"cypress": "^13.13.0",
Expand Down
13 changes: 6 additions & 7 deletions src/App.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,13 @@
import React from 'react';
import './App.scss';
import { Sum } from './components/Sum/Sum';

@mateacademy-ai-mentor mateacademy-ai-mentor Aug 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checklist item #2 violation: Must use template literal syntax for string interpolation inside tag content. Change {a} to `${a}`, {b} to `${b}`, and {a + b} to `${a + b}`.

@mateacademy-ai-mentor mateacademy-ai-mentor Aug 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates [CHECKLIST ITEM #2] - Use string interpolation inside tag content. The GOOD example shows using a SINGLE template literal: {`Sum of ${a} and ${b} is ${a + b}`}. Currently there are multiple separate template literals which makes it harder to see the final result. Use one template literal that contains the entire string.


export const App = () => (
<>
<p>Sum of 2 and 3 is 5</p>
<p>Sum of -5 and 5 is 0</p>
<p>Sum of 10 and 0 is 10</p>
<p>Sum of 0 and 5 is 5</p>
<p>Sum of 0 and 0 is 0</p>
{/* Replace paragraphs with Sum componets */}
{/* And remove commented lines :) */}
<Sum a={2} b={3} />
<Sum a={-5} b={5} />
<Sum a={10} />
<Sum b={5} />
<Sum />
</>
);
4 changes: 3 additions & 1 deletion src/components/Sum/Sum.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
// export const Sum = () => ();
export const Sum = ({ a = 0, b = 0 }) => (
<p>{`Sum of ${a} and ${b} is ${a + b}`}</p>
);
Loading