Skip to content

React Sum Props - #4396

Open
VadymMararenko wants to merge 1 commit into
mate-academy:masterfrom
VadymMararenko:develop
Open

React Sum Props#4396
VadymMararenko wants to merge 1 commit into
mate-academy:masterfrom
VadymMararenko:develop

Conversation

@VadymMararenko

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your implementation correctly fulfills all functional requirements - the Sum component works as expected, handles missing props with defaults, uses named export, and all required Sum instances are present in App.jsx. All tests pass. The only issue is a code style preference regarding string interpolation syntax in checklist item #2, which doesn't affect functionality. This is a minor style difference rather than a functional blocker, and your code produces the correct output.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Comment thread src/App.jsx
@@ -1,14 +1,17 @@
import React from 'react';
import './App.scss';
import { Sum } from './components/Sum/Sum';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #2 which requires string interpolation inside tag content. Use template literal syntax: {Sum of ${a} and ${b} is ${a + b}}

Comment on lines +2 to +3
<p>
Sum of {a} and {b} is {a + b}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #2: use string interpolation inside tag content. Replace with template literal: {Sum of ${a} and ${b} is ${a + b}}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants