Skip to content

Solution - #4390

Open
bakugan1-os wants to merge 2 commits into
mate-academy:masterfrom
bakugan1-os:develop
Open

Solution#4390
bakugan1-os wants to merge 2 commits into
mate-academy:masterfrom
bakugan1-os:develop

Conversation

@bakugan1-os

Copy link
Copy Markdown

No description provided.

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

I am requesting changes because the Sum component violates the explicit checklist requirement to use string interpolation inside tag content [CHECKLIST ITEM #2]. In src/components/Sum/Sum.jsx, on the line where the message is rendered, you are using multiple JSX expressions like {a} + {b} = {a + b} rather than a single template literal. The requirement specifies a format like {Sum of ${a} and ${b} is ${a + b}}, so the current approach does not meet the core checklist rule.

  • What to fix (critical): In Sum.jsx, update the render line to use a single template literal for the entire string, e.g., {Sum of ${a} and ${b} is ${a + b}}. This aligns with the required style and ensures consistency with the checklist.

Everything else looks solid: App.jsx correctly uses a named export and renders the five Sum components with the specified props, and one-line formatting is applied where appropriate. Please make the small change above to meet the checklist requirement. Great job overall—this should be a quick fix!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Comment thread src/components/Sum/Sum.jsx Outdated
Comment on lines +5 to +6
<p>
Sum of {a} and {b} is {a + b}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #2: 'Use string interpolation inside tag content'. The GOOD EXAMPLE shows using a template literal: {Sum of ${a} and ${b} is ${a + b}} instead of separate JSX expressions.

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your implementation meets all requirements and passes all checks. The Sum component correctly accepts a and b props with default values of 0, uses a single template literal for the message format "Sum of X and Y is Z", and exports using named export syntax. App.jsx properly renders all five required Sum instances with appropriate props in single-line format. Both files follow the checklist requirements including named exports and proper string interpolation in tag content [CHECKLIST ITEM #1 and #2]. Great work completing this task!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants