Skip to content

feat: add Sum component - #4388

Open
AchekcSs wants to merge 1 commit into
mate-academy:masterfrom
AchekcSs:develop
Open

feat: add Sum component#4388
AchekcSs wants to merge 1 commit into
mate-academy:masterfrom
AchekcSs:develop

Conversation

@AchekcSs

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your implementation is approved. All functional requirements are met: the Sum component accepts props with correct default values, renders the proper output format, uses named export, and App.jsx contains all five required Sum instances. The only noted issue is a code style preference regarding template literal usage (checklist item #2) in Sum.jsx. Since your code produces the correct output and functions properly, this style guideline is a non-critical preference that doesn't prevent task completion. Consider updating the paragraph to use template literal interpolation like {Sum of ${a} and ${b} is ${a + b}} for improved readability, but this doesn't block your approval. Great work on meeting all core requirements!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Comment thread src/App.jsx
Comment on lines +2 to 3
import { Sum } from './components/Sum/Sum';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #2: Use string interpolation inside tag content. The paragraph should use a template literal like {Sum of ${a} and ${b} is ${a + b}} instead of separate JSX expressions.

Comment on lines +2 to +3
<p>
Sum of {a} and {b} is {a + b}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to checklist item #2, you should use string interpolation inside tag content. Use a template literal instead: {Sum of ${a} and ${b} is ${a + b}}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants