add task solution - #4387
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your implementation is functionally correct and all tests pass. However, checklist item #2 is violated in both src/App.jsx and src/components/Sum/Sum.jsx. Instead of using separate JSX expressions {a}, {b}, and {a + b} inside the paragraph tag, you need to use template literal string interpolation: {Sum of ${a} and ${b} is ${a + b}}. While this is a minor code style issue, explicit checklist items must be followed per the submission requirements. Please update both files to use the template literal pattern as demonstrated in the checklist example.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
|
|
||
| export const App = () => ( |
There was a problem hiding this comment.
This violates checklist item #2: Use string interpolation inside tag content. Replace with template literal: {Sum of ${a} and ${b} is ${a + b}}
| <p> | ||
| Sum of {a} and {b} is {a + b} |
There was a problem hiding this comment.
This violates checklist item #2 - Use string interpolation inside tag content. Replace with template literal: {Sum of ${a} and ${b} is ${a + b}}
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your implementation fully satisfies all task requirements. The Sum component correctly accepts a and b props with default values of 0, renders the proper paragraph text using template literal string interpolation as required, and uses named export. Your App.jsx contains all five required Sum instances with appropriate props. The code follows the checklist requirements for one-line JSX tags and template literal usage. Great work completing this task!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
DEMO LINK