react sum - #4382
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
I am requesting changes because a required feature is missing and tests are failing. In src/App.jsx, the task requires five Sum components: a=2 b=3, a=-5 b=5, a=10 only, b=5 only, and one with no props at all. Currently only four are present; please add <Sum /> with no props (e.g., near line where other Sum components are rendered) to meet the specification. Additionally, the E2E test expects a default rendered sum of 4 when no params are provided; ensure the page-level defaults (likely in App.jsx) initialize values (e.g., a=2, b=2) so that a <p> displays 4 when no inputs are given. This aligns with the test “should contain a sum with no params” and will unblock CI.
Critical issues to fix:
- Add the missing no-props
Suminstance insrc/App.jsx(fifth component) to satisfy the required cases. - Ensure the page initializes default values so that the no-params state renders a
<p>containing4.
Minor note: Your Sum component implementation style looks good and passes component tests. Once these changes are made, everything should pass—nice work so far!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| <Sum a={2} b={3} /> | ||
| <Sum a={-5} b={5} /> | ||
| <Sum a={10} /> | ||
| <Sum b={5} /> |
There was a problem hiding this comment.
Missing required Sum component with no parameters. The task requires 5 Sum components, but only 4 are present. Add <Sum /> with no props to satisfy the requirement.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Here is my approval: your implementation meets all functional and checklist requirements. The Sum component uses a named export, applies default parameters for both a and b, and renders the correct string format. In App.jsx, all five required <Sum /> instances are present with the exact props: <Sum a={2} b={3} />, <Sum a={-5} b={5} />, <Sum a={10} />, <Sum b={5} />, and <Sum />. I did not find any critical or blocking issues—outputs are correct for the specified inputs and the code style aligns with the task guidelines. Nice work keeping the implementation clean and straightforward.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.