Skip to content

initial#940

Open
EStasyuk wants to merge 11 commits intomate-academy:masterfrom
EStasyuk:develop
Open

initial#940
EStasyuk wants to merge 11 commits intomate-academy:masterfrom
EStasyuk:develop

Conversation

@EStasyuk
Copy link
Copy Markdown

Copy link
Copy Markdown

@2pasha 2pasha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Something went wrong
Image Image
  1. remove unused code
  2. your ProductCard component is inside ProductList folder, it's little bit confused, it's better to create ProductCard folder as well
  3. try to pass all CI tests (linter and tests)

good job! 👏

please fix moments above

@EStasyuk EStasyuk requested a review from 2pasha March 18, 2026 20:22
Copy link
Copy Markdown

@2pasha 2pasha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job! 👏

here are some improvements:

  1. make sure that you have used correct fonts
  2. in this section products should be without any discount
Image
  1. fix this bug
Image
  1. user should have ability to visit Product details page on clicking here
Image
  1. you do not save items in card and as result after reload card is empty
Image
  1. add some message after clicking on checkout button
Image
  1. change title and favicon
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants