Skip to content

add task solution#3744

Open
Alibobick wants to merge 1 commit into
mate-academy:masterfrom
Alibobick:develop
Open

add task solution#3744
Alibobick wants to merge 1 commit into
mate-academy:masterfrom
Alibobick:develop

Conversation

@Alibobick
Copy link
Copy Markdown

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your implementation correctly fulfills all core functional requirements. The Person component properly destructures props, renders all required information with the correct class names, handles conditional age display, uses appropriate gender-specific partner terminology, and shows the "I am not married" message when applicable. There's a minor formatting preference noted in the checklist regarding the ternary operator on line 12 — the operands should ideally be on separate lines for readability (though this is a style preference rather than a functional issue). Your code works exactly as intended, and this style consideration won't affect how the component behaves. Great work on meeting all the functional requirements!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

{age && <p className="Person__age">I am {age}</p>}
{isMarried ? (
<p className="Person__partner">
{partnerName} {sex === 'm' ? 'is my wife' : 'is my husband'}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checklist Item #2 violation: The inner ternary operator operands should be on separate lines for better readability. Move each operand to its own line:

{partnerName} {
  sex === 'm' 
    ? 'is my wife' 
    : 'is my husband'
}```

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants