add task solution by Roma-Yamshchikov · Pull Request #3740 · mate-academy/react_person

Roma-Yamshchikov · 2026-05-17T01:09:46Z

mateacademy-ai-mentor

Review Summary

Your implementation correctly handles all functional requirements—the conditional age display, gender-aware partner naming, and marriage status messages all work as expected. However, there are three explicit checklist violations that need to be addressed: [CHECKLIST ITEM #1] In src/components/Person/Person.jsx, you're destructuring person from props but then accessing properties as person.name, person.age, etc. Instead, destructure all properties directly: const { name, age, sex, isMarried, partnerName } = person; [CHECKLIST ITEM #2] The ternary operator operands must be on separate lines for readability—format the condition, truthy value, and falsy value each on their own line. [CHECKLIST ITEM #3] Avoid nested ternary operators in JSX. Create a separate variable (e.g., const partnerLabel = sex === 'm' ? 'husband' : 'wife';) before the return statement and use that variable instead. The same destructuring issue exists in src/App.jsx. Once these checklist items are addressed, your solution will be complete.

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button² in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag³.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

mateacademy-ai-mentor · 2026-05-17T01:11:36Z

@@ -1,5 +1,6 @@
 import React from 'react';


This violates checklist item #1: Use destructuring for getting access to values of props object. The component should destructure all properties from the person object (name, age, isMarried, partnerName, sex) rather than accessing them via person.xxx throughout the component.

mateacademy-ai-mentor · 2026-05-17T01:11:36Z

@@ -1 +1,11 @@
-// export const Person = ({ person }) => ();
+export const Person = ({ person }) => (


Checklist item #1 violation: Use destructuring for accessing individual values. Destructure name, age, sex, isMarried, partnerName directly from props instead of accessing through person object. See the GOOD examples in checklist for the expected pattern.

mateacademy-ai-mentor · 2026-05-17T01:11:36Z

+      {person.isMarried
+        ? `${person.partnerName} is my ${person.sex === 'm' ? 'wife' : 'husband'}`


Checklist item #2 violation: Ternary operands must be on separate lines for readability. The condition and each operand should be on its own line.

mateacademy-ai-mentor · 2026-05-17T01:11:37Z

+    {person.age && <p className="Person__age">I am {person.age}</p>}
+    <p className="Person__partner">
+      {person.isMarried
+        ? `${person.partnerName} is my ${person.sex === 'm' ? 'wife' : 'husband'}`


Checklist item #3 violation: Avoid nested ternary operators and multiple cases in conditional rendering. Create a separate variable for the partner label (wife or husband) before the return statement.

mateacademy-ai-mentor

Review Summary

This solution requires changes before it can be approved. There are 2 critical issues that need fixing:

CHECKLIST VIOLATIONS (3 items): The code still has all 3 checklist violations from the previous review. In Person.jsx, you need to: (1) destructure name, age, sex, isMarried, partnerName from the person prop directly instead of accessing person.name etc.; (2) move ternary operands to separate lines with proper indentation; (3) extract the partner label (wife/husband) to a variable like const partnerLabel = sex === 'm' ? 'husband' : 'wife'; before the return statement instead of using a nested ternary in JSX.
TEST FAILURES: Two Cypress component tests are failing because your component outputs improper whitespace. The tests expect 'Natasha is my wife' but get 'Natasha is my\n wife' - this indicates your JSX text spans multiple lines or has incorrect interpolation formatting. Fix the partner relationship text to render as a clean single-line string on one line in your JSX.

These are critical blockers that prevent the task from being considered complete. Please address all checklist items and ensure your component produces clean text output.

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button² in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag³.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

mateacademy-ai-mentor · 2026-05-17T01:30:59Z

@@ -1 +1,12 @@
-// export const Person = ({ person }) => ();
+export const Person = ({ person }) => (


[CHECKLIST ITEM #1] Instead of accessing person.name, person.age, etc., destructure the properties from person directly: const { name, age, sex, isMarried, partnerName } = person;

mateacademy-ai-mentor · 2026-05-17T01:30:59Z

+      {person.isMarried
+        ? `${person.partnerName} is my
+        ${person.sex === 'm' ? 'wife' : 'husband'}`


[CHECKLIST ITEM #3] Avoid nested ternary inside the template string. Create a separate variable before the return: const partnerLabel = sex === 'm' ? 'wife' : 'husband'; and use it in the template.

mateacademy-ai-mentor · 2026-05-17T01:30:59Z

+      {person.isMarried
+        ? `${person.partnerName} is my
+        ${person.sex === 'm' ? 'wife' : 'husband'}`
+        : 'I am not married'}


[CHECKLIST ITEM #2] Format ternary operands correctly - move each operand to a separate line with proper indentation.

mateacademy-ai-mentor · 2026-05-17T01:30:59Z

@@ -1,5 +1,6 @@
 import React from 'react';


[CHECKLIST ITEM #1] This destructures only person and then accesses properties as person.name, person.age, etc. Instead, destructure all properties directly from props: export const Person = ({ name, age, sex, isMarried, partnerName }) => (

mateacademy-ai-mentor · 2026-05-17T01:30:59Z

@@ -1,5 +1,6 @@
 import React from 'react';
 import './App.scss';
+import { Person } from './components/Person/Person';


[CHECKLIST ITEM #1] Use destructured name instead of person.name

mateacademy-ai-mentor · 2026-05-17T01:30:59Z

 import React from 'react';
 import './App.scss';
+import { Person } from './components/Person/Person';



[CHECKLIST ITEM #1] Use destructured age instead of person.age

mateacademy-ai-mentor

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
_{[CODE: NCM]}

If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.

Anton-Kuchmasov

Good job!

Thread in fe_chat: https://mate.academy/chats/20895?selectedMessageId=11467880

add task solution

13ec2af

mateacademy-ai-mentor suggested changes May 17, 2026

View reviewed changes

Roma-Yamshchikov requested a review from mateacademy-ai-mentor May 17, 2026 01:29

mateacademy-ai-mentor suggested changes May 17, 2026

View reviewed changes

Roma-Yamshchikov requested a review from mateacademy-ai-mentor May 17, 2026 09:13

mateacademy-ai-mentor reviewed May 17, 2026

View reviewed changes

Roma-Yamshchikov force-pushed the develop branch from 8cb93f2 to 13ec2af Compare May 17, 2026 09:28

Roma-Yamshchikov requested a review from mateacademy-ai-mentor May 17, 2026 09:28

Anton-Kuchmasov approved these changes May 17, 2026

View reviewed changes

		@@ -1 +1,11 @@
		// export const Person = ({ person }) => ();
		export const Person = ({ person }) => (

		{person.isMarried
		? `${person.partnerName} is my ${person.sex === 'm' ? 'wife' : 'husband'}`

		@@ -1 +1,12 @@
		// export const Person = ({ person }) => ();
		export const Person = ({ person }) => (

Conversation

Roma-Yamshchikov commented May 17, 2026

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Review Summary

Footnotes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Review Summary

Footnotes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Uh oh!

Anton-Kuchmasov left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants