Develop#3737
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
The implementation needs a small but important fix. In src/components/Person/Person.jsx, the fallback message for unmarried status currently displays "not married", but the task requirement explicitly states it should display "I am not married". This is a direct requirement violation that would cause test failures.
To fix this, locate the ternary operator that handles the married/not married message and change the fallback text from "not married" to "I am not married". The rest of your implementation is correct—destructuring, conditional rendering, and component usage all meet the requirements.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| {person.partnerName} is my {partnerLabel} | ||
| </p> | ||
| ) : ( | ||
| <p className="Person__partner">not married</p> |
There was a problem hiding this comment.
The requirement states: 'If a person is not married, display the message "I am not married"'. Current text says 'not married' instead of 'I am not married'.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your implementation correctly meets all task requirements. The Person component properly displays person details with correct markup structure, handles the ternary operator formatting as specified, and shows the exact message "I am not married" for unmarried individuals. The entire person object is correctly passed as a prop, the optional age property is omitted when not present, and the partner label correctly uses "wife" for men and "husband" for women. All class names match the specification. No issues remaining - your solution is approved.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
https://lennlaaa.github.io/react_person/