Skip to content

version 1#3727

Open
dianakomar wants to merge 1 commit into
mate-academy:masterfrom
dianakomar:develop
Open

version 1#3727
dianakomar wants to merge 1 commit into
mate-academy:masterfrom
dianakomar:develop

Conversation

@dianakomar
Copy link
Copy Markdown

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your solution correctly implements all functional requirements for the Person component. The three person objects are rendered with proper destructuring, optional age handling, gender-based partner terminology, and correct marriage status messaging. The only issue noted is a minor formatting style concern regarding the ternary operator layout in src/components/Person/Person.jsx — this falls under code style preferences rather than a functional blocker, and such formatting guidelines are typically handled by linters in the development workflow. Great work on meeting the core requirements!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

{person.age && <p className="Person__age">I am {person.age}</p>}
{person.isMarried ? (
<p className="Person__partner">
{person.partnerName} is my {person.sex === 'm' ? 'wife' : 'husband'}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #2: Format ternary operator operands correctly - move each operand to the separate line. The ternary {person.sex === 'm' ? 'wife' : 'husband'} should be formatted across multiple lines for readability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants