added solution#3725
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your solution is approved. All functional requirements are correctly implemented: the Person component destructures props, handles optional age rendering, uses gender-based partner terminology, and applies the required class names throughout. The ternary operator formatting issue in src/components/Person/Person.jsx is a minor code style concern—your implementation works correctly, and the linter will provide specific formatting feedback for checklist item #2. The CI failures you saw were caused by a platform incompatibility in the build environment (Windows-specific dependencies on a Linux runner), not by any issue with your code. Your React implementation is solid and meets all the core requirements. Keep up the good work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| {isMarried | ||
| ? `${partnerName} is my ${sex === 'm' ? 'wife' : 'husband'}` | ||
| : 'I am not married'} |
There was a problem hiding this comment.
Checklist item #2 violation: The ternary operator formatting does not match the required pattern. Each operand should be on a separate line. Current format has isMarried and ? together on line 13, which doesn't follow the required pattern where the condition should be on its own line.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your implementation is approved. All functional requirements are correctly met: the Person component uses proper destructuring, renders gender-based partner terminology, handles optional age display, and the ternary operators follow the specified formatting with operands on separate lines [CHECKLIST ITEMS #1, #2, #3]. The test and linter failures you're seeing are due to a CI environment issue—the repository's package-lock.json contains Windows-specific dependencies that can't install on the Linux runner. This is not related to your code. You can verify your implementation works by running npm install --ignore-optional locally, or the repository maintainers would need to regenerate the lock file on a Linux environment. Great work on meeting all the task requirements!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
3 participants
DEMO LINK