Skip to content

Implement Person component and update App to use it#3721

Open
sonik-boom71 wants to merge 3 commits into
mate-academy:masterfrom
sonik-boom71:master
Open

Implement Person component and update App to use it#3721
sonik-boom71 wants to merge 3 commits into
mate-academy:masterfrom
sonik-boom71:master

Conversation

@sonik-boom71
Copy link
Copy Markdown

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your implementation fully meets all task requirements and I am approving it. The code correctly implements the Person component with proper conditional age rendering, gender-based partner terminology (wife/husband), and marriage status messaging. The App.jsx properly passes the person object and uses all three constants as specified. Code style requirements including destructuring and readable ternary formatting are satisfied. The failed check runs are due to a repository configuration issue with incompatible npm peer dependencies (eslint-plugin-n@17.24.0 vs eslint-config-standard@17.1.0), not any problems with your code. This is an infrastructure issue that needs to be resolved at the project level by either downgrading eslint-plugin-n to version 16 or adding --legacy-peer-deps to the CI workflow.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

…onfig-standard

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

The implementation fully meets all task requirements — both Person.jsx and App.jsx correctly handle optional age rendering, gender-based partner terminology (wife/husband), marriage status messaging, proper destructuring of props, and formatted ternary operators on separate lines. All [CHECKLIST ITEM #1], [CHECKLIST ITEM #2], and [CHECKLIST ITEM #3] items are satisfied. The CI failures are due to a peer dependency conflict in package.json between eslint-plugin-promise@^7.3.0 and eslint-config-standard@17.1.0, which expects eslint-plugin-promise@^6.0.0. Updating eslint-plugin-promise to "^6.0.0" resolves the issue.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

…int-config-standard

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

All three checklist items are properly implemented: props destructuring in Person.jsx, ternary operands formatted on separate lines, and separate variables used for conditional logic. The component correctly handles optional age rendering, gender-based partner terminology, and displays the appropriate marriage message. Great job passing the full person object as a prop and using the Person component three times in App.jsx — this demonstrates excellent React component composition skills. Keep up the solid work!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants