Skip to content

solution#4297

Open
o-koszalka wants to merge 1 commit intomate-academy:masterfrom
o-koszalka:develop
Open

solution#4297
o-koszalka wants to merge 1 commit intomate-academy:masterfrom
o-koszalka:develop

Conversation

@o-koszalka
Copy link

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Excellent work on this task! Your solution is approved. You've done a great job decomposing the application into separate components and correctly co-locating the CSS files with their respective components. The project structure is clean and meets all the requirements. The way you handled the Header component is perfectly acceptable; creating a separate Navigation component was optional, and your implementation is solid. Keep up the great work!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Comment on lines +27 to +44
.navigation__link {
display: inline-block;

padding: 0 0.5em;

color: black;
text-decoration: none;

opacity: 0.7;
outline: none;

transition: opacity 0.2s ease-in-out;
}

.navigation__link:hover,
.navigation__link:focus {
opacity: 1;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The task description suggests that the navigation could be its own component. If you were to do that, these navigation-related styles would move to a Navigation.css file. For this task, keeping them here is acceptable since the navigation is part of the Header component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants