Conversation
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this task! I am approving your solution as you've successfully decomposed the application into components with separate CSS files, meeting all the core requirements.
One area for future improvement is to ensure consistency between your exports and imports. While you correctly used export default for your components, you imported them using named imports (e.g., import { Article } from ...). The standard convention is to use a default import for a default export, like this:
import Article from './components/Article/Article';This is a best practice rather than a requirement for this task, but it's a good habit to adopt for cleaner and more predictable code. Keep up the great work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
| import { Article } from './components/Article/Article'; | ||
| import { Header } from './components/Header/Header'; | ||
| import { Welcome } from './components/Welcome/Welcome'; |
There was a problem hiding this comment.
The task requires components to use export default. While your components do have a default export, you are importing them here using named imports ({ Article }, { Header }, etc.). To be consistent with the requirement and best practices, you should use default imports instead.
For example:
import Article from './components/Article/Article';
| @@ -1,5 +1,11 @@ | |||
| // import a css file containig header styles | |||
| import './Header.css'; | |||
| import { Navigation } from './Navigation/Navigation'; | |||
There was a problem hiding this comment.
The task emphasizes using export default for all components. While your Navigation component does have a default export, you are importing it here as a named import. For consistency, you should use the default import instead:
import Navigation from './Navigation/Navigation';
DEMO LINK