Skip to content

Develop#155

Closed
Ivanovid777 wants to merge 4 commits intomate-academy:mainfrom
Ivanovid777:develop
Closed

Develop#155
Ivanovid777 wants to merge 4 commits intomate-academy:mainfrom
Ivanovid777:develop

Conversation

@Ivanovid777
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

This requires a few updates before it can be approved. You've made a good start on normalizing the database by creating the Warehouses table!

However, there are three critical issues that prevent the script from working as required:

  1. Incomplete Normalization: To achieve the third normal form (3NF), you need to create a separate Products table. The ProductInventory table should then use a foreign key (ProductID) instead of storing the ProductName directly, which currently causes data redundancy.
  2. Incorrect INSERT Statements: The INSERT statements for ProductInventory will fail because the number of columns specified does not match the number of values provided.
  3. Missing DROP DATABASE Statement: The task requires the script to include DROP DATABASE IF EXISTS ShopDB; at the beginning to ensure a clean setup.

Please address these points to complete the task. You're on the right track!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

@Ivanovid777 Ivanovid777 reopened this Mar 12, 2026
@Ivanovid777 Ivanovid777 deleted the develop branch March 12, 2026 14:55
@Ivanovid777 Ivanovid777 restored the develop branch March 12, 2026 14:55
@Ivanovid777 Ivanovid777 reopened this Mar 12, 2026
@Ivanovid777 Ivanovid777 deleted the develop branch March 12, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants