Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great work on this task! You've built a solid HTTP server that handles most of the requirements correctly. However, there is one important issue that needs to be addressed before this can be approved. Your server doesn't correctly handle URL-encoded characters in the path. For example, if a user sends a request with a space like /hello%20world, your code attempts to convert the literal string hello%20world instead of the decoded text hello world. To fix this, you should decode the text extracted from the URL path. Take a look at the global decodeURIComponent() function, which is designed for this purpose. Once that's sorted, you'll be all set!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/createServer.js
Outdated
| function createServer() { | ||
| const server = http.createServer((req, res) => { | ||
| const [urlText, query] = req.url.split('?'); | ||
| const textToConvert = urlText.slice(1); |
There was a problem hiding this comment.
The text extracted from the URL path should be decoded. If the URL contains percent-encoded characters (like %20 for a space), this implementation will try to convert the encoded string instead of the actual text. Consider using decodeURIComponent() to handle this correctly.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this iteration! You've successfully addressed the previous feedback by using decodeURIComponent to correctly handle URL-encoded characters. The server now fully meets all functional and technical requirements, from validation and error handling to the specific response formatting. Your solution is approved, great job!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.