Implemented getReminder() and calculateTotalPrice() - #151
Open
ddryzhov wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Implements the previously stubbed Kotlin utility functions for computing a total price with a default unit price and for transforming a numeric string into a remainder value.
Changes:
- Implement
calculateTotalPrice()to apply a default unit price whenpricePerProductis null and multiply bycount. - Implement
getReminder()to parse an optional numeric string and compute(n * 3 + 10) % 11.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main/kotlin/mate/academy/TotalPrice.kt | Adds default-price handling and computes total price. |
| src/main/kotlin/mate/academy/NumberTransformation.kt | Adds parsing and transformation logic for the remainder calculation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| fun getReminder(numberStr: String?) : Int? { | ||
| return null | ||
| return numberStr?.toIntOrNull()?.let { number -> (number * 3 + 10) % 11 } |
There was a problem hiding this comment.
The arithmetic (number * 3 + 10) is performed in Int and can overflow for large (but still valid) Int inputs, producing an incorrect remainder. Consider doing the computation in Long (or using exact math) before applying % 11 and returning the Int result.
Suggested change
| return numberStr?.toIntOrNull()?.let { number -> (number * 3 + 10) % 11 } | |
| return numberStr?.toIntOrNull()?.let { number -> ((number.toLong() * 3 + 10) % 11).toInt() } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.