Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job on the overall structure and the implementation of the sortList function! However, changes are needed because the getEmployees function isn't returning the correct data. Inside your .map() callback, you're using the lis variable (the entire <ul>) to access employee data for every iteration. Instead, you should use the li parameter provided by the callback, which represents the individual <li> for each employee. Correcting this to use li.textContent and li.dataset will fix the issue. Keep up the excellent work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/scripts/main.js
Outdated
| name: lis.textContent, | ||
| salary: getSalary(lis), | ||
| position: lis.dataset.position, | ||
| age: Number(lis.dataset.age), |
There was a problem hiding this comment.
It looks like you're using lis (the entire list <ul>) to get the properties for each employee. The map function's callback provides li which represents the individual list item (<li>) for the current iteration. You should use li to access the specific data for each employee.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work! You've successfully addressed the feedback from the previous review and fixed the issue in the getEmployees function. The code now correctly implements all requirements, properly sorting the list and generating the employee objects. The solution is clean and well-structured, so I am happy to approve it. Great job!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.