Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on the sortList function—it correctly reorders the elements on the page! However, I am requesting changes because the getEmployees function does not meet the task requirements. It currently uses forEach, which doesn't return a value, so the function itself returns undefined instead of the required array. To fix this, you should use the .map() method to transform the list items into a new array. Remember that the callback for .map() should create and return an object for each employee with the specified schema: { name, position, salary, age }.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/scripts/main.js
Outdated
| people.forEach((person) => { | ||
| const name1 = person.textContent.trim(); | ||
| const position = person.dataset.position; | ||
| const salary = person.dataset.salary; | ||
| const age = person.dataset.age; | ||
|
|
||
| return `Name: ${name1}, Position: ${position}, Salary: ${salary}, Age: ${age}`; | ||
| }); |
There was a problem hiding this comment.
This function should return an array of employee objects, but forEach doesn't return anything. To create a new array by transforming each element, you should use the .map() method instead. Additionally, the callback for this method should create and return an object with the schema { name, position, salary, age }, not a string.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this pull request! You've successfully addressed the feedback from the previous review by refactoring the getEmployees function. The code is now clean, functional, and correctly uses the .map() method to return the required array of employee objects. Since all requirements have been met and there are no outstanding issues, I am approving your submission. Well done!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
https://Ivadriil.github.io/js_task_parse_list_DOM/
https://mate-academy.github.io/layout_task-guideline/