Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job on this task! The logic for sorting the list and parsing the salaries is well-implemented. However, I am requesting a small change because there's an issue that prevents the getEmployees function from working correctly. You've defined the function to accept a list element as an argument, but when you call it, you're not passing anything, which will cause a runtime error. To fix this, please pass the list variable to the getEmployees function, just like you did for the sortList function. Once you make that change, everything should work as expected!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/scripts/main.js
Outdated
| }); | ||
| } | ||
| sortList(list); | ||
| getEmployees(); |
There was a problem hiding this comment.
The getEmployees function expects a list element as an argument, but it's being called without one. You should pass the list variable to this function, similar to how you called sortList.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this submission! You've successfully addressed the feedback from the previous review by correctly passing the list variable to the getEmployees function. The code is now clean, well-structured, and fully meets all the task requirements. The logic for sorting and parsing the data is solid. I am happy to approve your solution, great job!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.