Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
1. Replace `<your_account>` with your Github username in the link
- [DEMO LINK](https://<your_account>.github.io/js_task_parse_list_DOM/)
- [DEMO LINK](https://pavloPolyvoda-dev.github.io/js_task_parse_list_DOM/)
2. Follow [this instructions](https://mate-academy.github.io/layout_task-guideline/)
- Run `npm run test` command to test your code;
- Run `npm run test:only -- -n` to run fast test ignoring linter;
Expand All @@ -10,14 +10,14 @@
Hey there! Can you parse data from the list and sort it based on data attributes?

Your task: Sort list by salary in descending order.
Get an array of employees. Write two functions:
Get an array of employees. Write two functions:
- first, which sorts the list by salary from data attributes
- second, which returns an array of objects, where objects are employees.

The schema for the employee:
```
{
name,
name,
position,
salary,
age
Expand Down
33 changes: 32 additions & 1 deletion src/scripts/main.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,34 @@
'use strict';

// write code here
const employeesList = document.querySelector('ul');

function parseSalary(item) {
return Number(item.dataset.salary.replace(/[^0-9.-]+/g, ''));
}

function sortList(list) {
const items = Array.from(list.children);

items.sort((a, b) => parseSalary(b) - parseSalary(a));

items.forEach((item) => list.appendChild(item));
}

function getEmployees(list) {
return Array.from(list.children).map((employee) => {
const nameEmp = employee.textContent.trim();
const position = employee.dataset.position;
const salary = Number(employee.dataset.salary.replace(/[^0-9.-]+/g, ''));
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line duplicates the logic from the parseSalary helper function. To avoid repetition and keep your code DRY (Don't Repeat Yourself), you can reuse the helper function here:

const salary = parseSalary(employee);


return {
name: nameEmp,
position,
salary,
age: Number(employee.dataset.age),
};
});
}

sortList(employeesList);

getEmployees(employeesList);