Skip to content
Open

Develop #1923

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions .github/workflows/test.yml-template
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
name: Test

on:
pull_request:
branches: [ master ]

jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [20.x]

steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm start & sleep 5 && npm test
- name: Upload tests report(cypress mochaawesome merged HTML report)
if: ${{ always() }}
uses: actions/upload-artifact@v2
with:
name: report
path: reports
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
1. Replace `<your_account>` with your Github username in the link
- [DEMO LINK](https://<your_account>.github.io/js_task_parse_list_DOM/)
- [DEMO LINK](https://uselessmorning.github.io/js_task_parse_list_DOM/)
2. Follow [this instructions](https://mate-academy.github.io/layout_task-guideline/)
- Run `npm run test` command to test your code;
- Run `npm run test:only -- -n` to run fast test ignoring linter;
Expand All @@ -10,14 +10,14 @@
Hey there! Can you parse data from the list and sort it based on data attributes?

Your task: Sort list by salary in descending order.
Get an array of employees. Write two functions:
Get an array of employees. Write two functions:
- first, which sorts the list by salary from data attributes
- second, which returns an array of objects, where objects are employees.

The schema for the employee:
```
{
name,
name,
position,
salary,
age
Expand Down
9 changes: 5 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"@linthtml/linthtml": "^0.9.6",
"@mate-academy/eslint-config": "latest",
"@mate-academy/linthtml-config": "latest",
"@mate-academy/scripts": "^1.8.5",
"@mate-academy/scripts": "^2.1.3",
"@mate-academy/stylelint-config": "latest",
"@parcel/transformer-sass": "^2.12.0",
"cypress": "^13.13.0",
Expand Down
36 changes: 36 additions & 0 deletions src/scripts/main.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,39 @@
'use strict';

// write code here

const toNum = (str) => Number(String(str || '').replace(/[$,]/g, ''));

function sortList(list) {
const items = Array.from(list.children);

items.sort((a, b) => {
const salaryA = toNum(a.dataset.salary);
const salaryB = toNum(b.dataset.salary);

const validA = Number.isFinite(salaryA) ? salaryA : 0;
const validB = Number.isFinite(salaryB) ? salaryB : 0;

return validB - validA;
});

list.append(...items);
}

function getEmployees(list) {
const items = Array.from(list.children);

return items.map((item) => {
return {
name: item.querySelector('.name').textContent.trim(),
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accessing item.querySelector('.name').textContent.trim() without checking the query result can throw if the .name element is missing. Per the requirements you must guard for a missing node before using .textContent (for example: const nameEl = item.querySelector('.name'); name: nameEl ? nameEl.textContent.trim() : '').

position: item.querySelector('.position').textContent.trim(),
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for .position: calling item.querySelector('.position').textContent.trim() assumes the node exists. Add a null check or optional chaining with a fallback to avoid runtime errors (e.g. const posEl = item.querySelector('.position'); position: posEl ? posEl.textContent.trim() : '').

salary: toNum(item.dataset.salary),
age: Number(item.dataset.age),
};
});
Comment on lines +26 to +33
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getEmployees returns objects with only name and salary, but the task requires the schema { name, position, salary, age }. Also name is taken from item.textContent.trim(), which will include other fields and whitespace. Update this function to select specific child elements (for example item.querySelector('.name') and item.querySelector('.position')) and parse age to a number. Example shape to return:

{
  name: item.querySelector('.name').textContent.trim(),
  position: item.querySelector('.position').textContent.trim(),
  salary: toNum(item.dataset.salary),
  age: Number(item.dataset.age)
}

This change is required to meet the checklist item demanding the exact employee schema.

}

const employeesList = document.querySelector('ul');

sortList(employeesList);
getEmployees(employeesList);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You call getEmployees(employeesList); but do not store its return value. The task asks to "get an array of employees" — capture the result so it's available (for example: const employees = getEmployees(employeesList);).

Loading