-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Develop #1923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Develop #1923
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| name: Test | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: [ master ] | ||
|
|
||
| jobs: | ||
| build: | ||
|
|
||
| runs-on: ubuntu-latest | ||
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [20.x] | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Use Node.js ${{ matrix.node-version }} | ||
| uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| - run: npm install | ||
| - run: npm start & sleep 5 && npm test | ||
| - name: Upload tests report(cypress mochaawesome merged HTML report) | ||
| if: ${{ always() }} | ||
| uses: actions/upload-artifact@v2 | ||
| with: | ||
| name: report | ||
| path: reports |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,39 @@ | ||
| 'use strict'; | ||
|
|
||
| // write code here | ||
|
|
||
| const toNum = (str) => Number(String(str || '').replace(/[$,]/g, '')); | ||
|
|
||
| function sortList(list) { | ||
| const items = Array.from(list.children); | ||
|
|
||
| items.sort((a, b) => { | ||
| const salaryA = toNum(a.dataset.salary); | ||
| const salaryB = toNum(b.dataset.salary); | ||
|
|
||
| const validA = Number.isFinite(salaryA) ? salaryA : 0; | ||
| const validB = Number.isFinite(salaryB) ? salaryB : 0; | ||
|
|
||
| return validB - validA; | ||
| }); | ||
|
|
||
| list.append(...items); | ||
| } | ||
|
|
||
| function getEmployees(list) { | ||
| const items = Array.from(list.children); | ||
|
|
||
| return items.map((item) => { | ||
| return { | ||
| name: item.querySelector('.name').textContent.trim(), | ||
| position: item.querySelector('.position').textContent.trim(), | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same for |
||
| salary: toNum(item.dataset.salary), | ||
| age: Number(item.dataset.age), | ||
| }; | ||
| }); | ||
|
Comment on lines
+26
to
+33
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
{
name: item.querySelector('.name').textContent.trim(),
position: item.querySelector('.position').textContent.trim(),
salary: toNum(item.dataset.salary),
age: Number(item.dataset.age)
}This change is required to meet the checklist item demanding the exact employee schema. |
||
| } | ||
|
|
||
| const employeesList = document.querySelector('ul'); | ||
|
|
||
| sortList(employeesList); | ||
| getEmployees(employeesList); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You call |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accessing
item.querySelector('.name').textContent.trim()without checking the query result can throw if the.nameelement is missing. Per the requirements you must guard for a missing node before using.textContent(for example:const nameEl = item.querySelector('.name'); name: nameEl ? nameEl.textContent.trim() : '').