Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on structuring the code to generate the table dynamically! The implementation is clean and almost perfect. However, one change is needed before this can be approved. The calculation for the 'Century' column is incorrect. According to the task requirements, the century should be calculated based on the year the person died (person.died), but your code currently uses the year they were born (person.born). Please update this logic to match the requirement. Once you've made that fix, your solution will be complete!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/scripts/main.js
Outdated
| bornCell.textContent = person.born; | ||
| diedCell.textContent = person.died; | ||
| ageCell.textContent = person.died - person.born; | ||
| centuryCell.textContent = Math.ceil(person.born / 100); |
There was a problem hiding this comment.
The calculation for the century is incorrect. According to the task requirements, it should be based on the year the person died (person.died), not the year they were born.
2 participants
https://Ivadriil.github.io/js_task_generate_table_DOM/ - demo link
https://mate-academy.github.io/layout_task-guideline/ - this instruct