Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
1. Replace `<your_account>` with your Github username in the link
- [DEMO LINK](https://<your_account>.github.io/js_task_generate_table_DOM/)
- [DEMO LINK](https://Yevhen-Srdk.github.io/js_task_generate_table_DOM/)
2. Follow [this instructions](https://mate-academy.github.io/layout_task-guideline/)
- Run `npm run test` command to test your code;
- Run `npm run test:only -- -n` to run fast test ignoring linter;
Expand All @@ -14,12 +14,12 @@ Okay, now we know what is a table, and can do some magic.
In `main.js`, you already have imported file `people.json`. Variable `people` contains an array of people, you can check it by using `console.log`.
Your task today is to convert this array to table rows.

Your layout for start:
Your layout for start:

![Preview](./src/images/preview.png)

From the preview, you can see that table has 6 headers, but our data does not contain age and century. Yes, you need to calculate them by yourself.

##### Steps to do this challenge:
1) For each person from `people` array create table row with 6 table cells (name, gender, born, died, age, century)
2) Find a table with class `dashboard` in the document.
Expand Down
36 changes: 33 additions & 3 deletions src/scripts/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,37 @@ const people = [
},
];

// eslint-disable-next-line no-console
console.log(people); // you can remove it
people.forEach((person) => {
person.age = getPersonAge(person);
person.century = getPersonCentury(person);
});
Comment on lines +357 to +360
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This loop iterates over the people array to add age and century properties, and then a second loop on line 365 iterates over it again to build the table. These two operations can be combined into a single loop for better efficiency.

This would also allow you to avoid modifying (mutating) the original person objects, which is a good practice to prevent unexpected side effects. The values for age, century, and the formatted gender can be calculated and used directly when creating the table cells.


// write your code here
const table = document.querySelector('.dashboard');
const tableBody = table.querySelector('tbody');

people.forEach((person) => {
const tableRow = document.createElement('tr');

person.sex = person.sex === 'm' ? 'Male' : 'Female';

[
person.name,
person.sex,
person.born,
person.died,
person.age,
person.century,
].forEach((personData, i) => {
tableRow.insertCell(i).textContent = personData;
});

tableBody.append(tableRow);
});

function getPersonAge(person) {
return person.died - person.born;
}

function getPersonCentury(person) {
return Math.ceil(person.died / 100);
}
Loading