Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job on the core logic! You've correctly calculated the age and century for each person and appended the new rows to the table. However, one change is needed before this can be approved. You've used a <th> (table header) tag for the name cell inside the table body. The <th> tag is intended for headers in the <thead> and alters the default styling, which goes against the requirement to not change the layout. Please use a <td> (table data) tag for the name cell, just like the other cells in the row, to ensure the HTML is semantically correct.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/scripts/main.js
Outdated
|
|
||
| // write your code here | ||
| people.forEach(({ name: personName, sex, born, died, slug }) => { | ||
| const nameCell = `<th>${personName}</th>`; |
There was a problem hiding this comment.
The <th> tag is intended for table headers, which are usually located in the <thead> element. For table data cells within the <tbody>, you should use the <td> tag. Using <th> here alters the semantic structure and default styling of the table, which goes against the requirement to not change the layout.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work! I am approving this submission. You've successfully addressed the previous feedback, and the code now correctly generates the table rows with <td> cells and implements all required calculations. Don't worry about the failed check run; it was caused by an environment issue unrelated to your code. Your solution is clean and meets all task specifications. Well done!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
DEMO LINK