Skip to content

edit#1842

Open
MarianaKlochnyk wants to merge 1 commit intomate-academy:masterfrom
MarianaKlochnyk:develop
Open

edit#1842
MarianaKlochnyk wants to merge 1 commit intomate-academy:masterfrom
MarianaKlochnyk:develop

Conversation

@MarianaKlochnyk
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Excellent work on this task! Your solution meets all the core requirements by correctly adding styled labels and capitalized placeholders to the form inputs. I'm happy to approve your submission.

For future reference, consider making your element selector more specific. While document.querySelectorAll('input') works here, using document.querySelectorAll('form input') would be more robust as it guarantees you only select inputs inside the form, which aligns more closely with the task description. This is a minor point but a good practice for more complex pages. Keep up the great coding!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

'use strict';

// write code here
const getInput = document.querySelectorAll('input');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the task description, you should get all input elements specifically from the form tag. Your current selector document.querySelectorAll('input') will select all inputs on the entire page. To be more precise and avoid potential issues on pages with inputs outside the form, consider using a selector like 'form input'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants