Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Good work on the core logic! The calculations and number formatting are correct. However, I'm requesting a small change to meet the display requirements. The task specifies replacing the placeholder text with only the calculated number, but your code adds prefixes like "Total: " and "Average: ". Please remove these prefixes from the textContent assignments for the total-population and average-population spans. After that small fix, everything should be perfect!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/scripts/main.js
Outdated
| const averageElement = document.querySelector('.average-population'); | ||
|
|
||
| if (totalElement && averageElement) { | ||
| totalElement.textContent = `Total: ${totalPopulation.toLocaleString()}`; |
There was a problem hiding this comment.
According to the task description and the preview image, you should only replace the content of the span with the calculated number. The prefix "Total: " is not required here.
src/scripts/main.js
Outdated
|
|
||
| if (totalElement && averageElement) { | ||
| totalElement.textContent = `Total: ${totalPopulation.toLocaleString()}`; | ||
| averageElement.textContent = `Average: ${Math.round(averagePopulation).toLocaleString()}`; |
There was a problem hiding this comment.
Similarly here, the element's text content should be just the formatted number, without the "Average: " prefix.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this pull request! You've successfully addressed the feedback from the previous review, and the code now correctly implements all the task requirements. The logic for parsing, calculating, and formatting the data is clean and effective. I am approving your solution. Well done!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
https://github.com/PAVLO111/js_get_data_DOM.git