Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job on implementing the core logic for calculating and displaying the population data! However, this submission requires a couple of changes before it can be approved.
The main issue is that a critical requirement was not met: the task explicitly stated to only modify the main.js file. Your submission includes changes to src/styles/_fonts.scss and src/styles/main.scss, which need to be reverted.
Additionally, to make your JavaScript code more robust, please address the edge cases mentioned in the comments:
- Data Validation: Ensure that text from a
<span>is a valid number before adding it to your total to avoidNaNerrors. - Division by Zero: Handle the case where no population data is found to prevent dividing by zero, which results in
Infinity.
Once you revert the style changes and add these checks, your solution will be in great shape!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| populationList.forEach((element) => { | ||
| const raw = element.textContent.trim(); | ||
| const cleaned = raw.replace(/\s+/g, '').replace(/,/g, ''); | ||
| const num = Number(cleaned); | ||
|
|
||
| result.push(num); | ||
| }); |
There was a problem hiding this comment.
This loop correctly processes the population data. However, requirement #2 asks you to 'Make sure that the given string can be converted to a number'. What would happen if element.textContent contained non-numeric text? The num variable would become NaN, which would cause total and average to also be NaN. It's a good practice to add a check to ensure num is a valid number before adding it to the result array.
src/scripts/main.js
Outdated
| }); | ||
|
|
||
| const total = result.reduce((sum, people) => sum + people, 0); | ||
| const average = Math.round(total / result.length); |
There was a problem hiding this comment.
This calculation is correct, but there's a potential edge case. If the result array is empty (for example, if no valid population numbers are found), result.length will be 0. Dividing by zero will result in Infinity. You should consider adding a check to handle this scenario, for example, by setting average to 0 if the array is empty.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on refining the JavaScript logic in main.js! The data validation and edge case handling are now very robust.
However, I am requesting changes because the submission still includes modifications to files other than main.js, which violates a core requirement of the task. The instructions state that only the main.js file should be changed.
Please revert the changes made to src/styles/_fonts.scss and src/styles/main.scss and remove them from your pull request. Once that single issue is resolved, your solution will be ready for approval!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/styles/_fonts.scss
Outdated
| @font-face { | ||
| font-family: Roboto, Arial, Helvetica, sans-serif; | ||
| src: url('../fonts/Roboto-Regular-webfont.woff') format('woff'); | ||
| font-weight: normal; | ||
| font-style: normal; | ||
| src: url('../fonts/Roboto-Regular-webfont.woff') format('woff'); |
There was a problem hiding this comment.
This file, along with src/styles/main.scss, should not be modified or included in your submission. The task instructions clearly state that only the main.js file should be changed. Please revert any changes to the style files and remove them from your pull request.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on the JavaScript logic in main.js! Your implementation for parsing data, performing calculations, and formatting the output is clean and correct.
However, this pull request includes changes to files other than main.js, which goes against a key requirement of the task. I am approving this as an educational exception to help you move forward. For future tasks, please pay close attention to the instructions and ensure you only modify the specified files.
Keep up the fantastic work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.